Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

From: Thomas Zimmermann
Date: Fri Feb 09 2024 - 15:24:24 EST


Am 09.02.24 um 06:15 schrieb Michael Ellerman:
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
Am 07.02.24 um 17:13 schrieb Randy Dunlap:
When VIDEO is not set, there is a build error. Fix that by selecting

ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!

Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxx>
Cc: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxx>
Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
Cc: Geoff Levand <geoff@xxxxxxxxxxxxx>
Acked-by: Geoff Levand <geoff@xxxxxxxxxxxxx>
Cc: linux-fbdev@xxxxxxxxxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Can you take it via whatever tree the CONFIG_VIDEO patch is in?

The patch is now in drm-misc-next.

Best regards

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>


Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)