Re: [PATCH] Input: xpad - sort xpad_device by vendor and product ID

From: Dmitry Torokhov
Date: Fri Feb 09 2024 - 13:56:40 EST


Hi Brenton,

On Tue, Jan 30, 2024 at 11:19:03PM +0000, Brenton Simpson wrote:
> Signed-off-by: Brenton Simpson <appsforartists@xxxxxxxxxx>

Empty patch descriptions are frowned upon. You should be able to add at
least a single sentence why the change is being made.

..

>
> static const struct usb_device_id xpad_table[] = {
> + /* Please keep this list sorted by vendor ID. Because the lines use different
> + * macros, you may need to sort it by hand.
> + */

Kernel style of multi-line comments is:

/*
* line 1
* line 2.
*/

I adjusted and applied, thank you.

Thanks.

--
Dmitry