Re: [PATCH v15-RFC 2/8] x86/resctrl: Move all monitoring functions to RDT_RESOURCE_L3_MON

From: Tony Luck
Date: Fri Feb 09 2024 - 13:51:35 EST


On Fri, Feb 09, 2024 at 09:28:25AM -0600, Moger, Babu wrote:
> Tony,
>
> On 1/30/24 16:20, Tony Luck wrote:
> > Switch over all places that setup and use monitoring funtions to
>
> functions?

Yes. Will fix.

> > use the new resource structure.
> >
> > Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> > ---
> > arch/x86/kernel/cpu/resctrl/core.c | 6 ++++--
> > arch/x86/kernel/cpu/resctrl/monitor.c | 12 ++++--------
> > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 2 +-
> > 3 files changed, 9 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> > index c50f55d7790e..0828575c3e13 100644
> > --- a/arch/x86/kernel/cpu/resctrl/core.c
> > +++ b/arch/x86/kernel/cpu/resctrl/core.c
> > @@ -591,11 +591,13 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r)
> > return;
> > }
> >
> > - if (r == &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl) {
> > + if (r == &rdt_resources_all[RDT_RESOURCE_L3_MON].r_resctrl) {
> > if (is_mbm_enabled() && cpu == d->mbm_work_cpu) {
> > cancel_delayed_work(&d->mbm_over);
> > mbm_setup_overflow_handler(d, 0);
> > }
> > + }
> > + if (r == &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl) {
>
> RDT_RESOURCE_L3_MON?

Good catch.

-Tony