Re: [PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices

From: Abhinav Kumar
Date: Fri Feb 09 2024 - 13:44:32 EST




On 2/8/2024 7:01 AM, Dmitry Baryshkov wrote:
Existing MDP5 devices have slightly different bindings. The main
register region is called `mdp_phys' instead of `mdp'. Also vbif
register regions are a part of the parent, MDSS device. Add support for
handling this binding differences.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 98 ++++++++++++++++++++++++++-------
drivers/gpu/drm/msm/msm_drv.h | 3 +
drivers/gpu/drm/msm/msm_io_utils.c | 13 +++++
3 files changed, 93 insertions(+), 21 deletions(-)


I thought we had agreed on a quite version of msm_ioremap_mdss for vbif_nrt_phys?

Anyway, its not something to block this change. Hence,

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>