Re: [PATCH] platform/x86: think-lmi: Fix password opcode ordering for workstations

From: Mark Pearson
Date: Fri Feb 09 2024 - 11:23:38 EST

Thanks Ilpo

On Fri, Feb 9, 2024, at 10:34 AM, Ilpo Järvinen wrote:
> On Fri, 9 Feb 2024, Mark Pearson wrote:
>> The Lenovo workstations require the password opcode to be run before
>> the attribute value is changed (if Admin password is enabled).
>> Tested on some Thinkpads to confirm they are OK with this order too.
>> Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Would a Fixes tag be appropriate here?

Hmmm - good point, though it has been "wrong" since it was originally implemented (where we tested on Thinkpads).

I guess I could use the commit ID from when I originally implemented opcodes?
Fixes: 640a5fa ("platform/x86: think-lmi: Opcode support")

Do you want me to push a new version with this?