Re: RE: [v3 4/6] drm/vs: Add KMS crtc&plane

From: Maxime Ripard
Date: Fri Feb 09 2024 - 10:37:22 EST

Next message:
Previous
Messages

On Thu, Feb 01, 2024 >
>
>
>
> > -----Original >
> > From: Maxime >
> > Sent: 2024ק >
> > To: Keith >
> > Cc: devicetree@x >
> > linux-kernel@xxxxxxxxxxxxxxx; >
> > tzimmermann@xxxxxxx; >
> > William >
> > <xingyu.wu@xx >
> > aou@xxxxxxxxxxxxxxxxx; >
> > Shengyang >
> > <jack.zhu@xxx >
> > <changhuang.l >
> > Subject: >
> >
>
> > On Wed, >
> > >
>
> > >
>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
>
> > > > >
> > > > >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > ARRAY_SIZE(secon >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > ARRAY_SIZE(secon >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > +};
>
> > > > > +
>
> > > > >
> > > > > + .name >
> > > > > + >
> > > > > + >
> > > > > + .planes >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > + >
> > > > > +};
>
> > > >
>
> > > > >
> > binding.
>
> > > > >
> > > > >
> > > >
>
> >
>
> > > I >
> > > terms >
> > > they >
> > > representing >
> > > ctrc >
> >
>
> > What are >
>
>
> [cid:image001.png@01D >
> For example:
>
> like this , >
> A similar situation >
>
>
> Another case >
> instead of crtc0 >
> reg:
>
> crtc0 X
>
> crtc1 X+4
>
> crtc0 X+8
>
> crtc1 X+12
>
> if to make it
Yeah, ok, that makes sense then.

In which case, if we're the planes and CRTCs, make your driver probe
Maxime

Attachment: Description: PGP signature Andrew Lunn: "Re: [PATCH v3 2/2] net: phy: dp83826: support TX data voltage tuning" message: Ilya Dryomov: "[GIT PULL] Ceph fixes for 6.8-rc4" sorted by: [ date ] [ thread ] [ subject ] [ author ] at 02:22:16AM +0000, Keith Zhao wrote:
Message-----
Ripard <mripard@xxxxxxxxxx>
4;1月31日 21:24
Zhao <keith.zhao@xxxxxxxxxxxxxxxx>
xxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
linux-riscv@xxxxxxxxxxxxxxxxxxx;
airlied@xxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
Qiu <william.qiu@xxxxxxxxxxxxxxxx>; Xingyu Wu
xxxxxxxxxxxxxx>; paul.walmsley@xxxxxxxxxx;
palmer@xxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx;
Chen <shengyang.chen@xxxxxxxxxxxxxxxx>; Jack Zhu
xxxxxxxxxxxxx>; Changhuang Liang
iang@xxxxxxxxxxxxxxxx>; maarten.lankhorst@xxxxxxxxxxxxxxx
Re: [v3 4/6] drm/vs: Add KMS crtc&plane
Jan 31, 2024 at 09:33:06AM +0000, Keith Zhao wrote:
-----邮件原件-----
发件人: Maxime Ripard <mripard@xxxxxxxxxx<mailto:mripard@xxxxxxxxxx>>
发送时间: 2023年12月6日 16:56
收件人: Keith Zhao <keith.zhao@xxxxxxxxxxxxxxxx<mailto:keith.zhao@xxxxxxxxxxxxxxxx>>
抄送: devicetree@xxxxxxxxxxxxxxx<mailto:devicetree@xxxxxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx<mailto:dri-devel@xxxxxxxxxxxxxxxxxxxxx>;
linux-kernel@xxxxxxxxxxxxxxx<mailto:linux-kernel@xxxxxxxxxxxxxxx>; linux-riscv@xxxxxxxxxxxxxxxxxxx<mailto:linux-riscv@xxxxxxxxxxxxxxxxxxx>;
tzimmermann@xxxxxxx<mailto:tzimmermann@xxxxxxx>; airlied@xxxxxxxxx<mailto:airlied@xxxxxxxxx>;
krzysztof.kozlowski+dt@xxxxxxxxxx<mailto:krzysztof.kozlowski+dt@xxxxxxxxxx>;
William Qiu <william.qiu@xxxxxxxxxxxxxxxx<mailto:william.qiu@xxxxxxxxxxxxxxxx>>; Xingyu Wu
<xingyu.wu@xxxxxxxxxxxxxxxx<mailto:xingyu.wu@xxxxxxxxxxxxxxxx>>; paul.walmsley@xxxxxxxxxx<mailto:paul.walmsley@xxxxxxxxxx>;
aou@xxxxxxxxxxxxxxxxx<mailto:aou@xxxxxxxxxxxxxxxxx>; palmer@xxxxxxxxxxx<mailto:palmer@xxxxxxxxxxx>; p.zabel@xxxxxxxxxxxxxx<mailto:p.zabel@xxxxxxxxxxxxxx>;
Shengyang Chen <shengyang.chen@xxxxxxxxxxxxxxxx<mailto:shengyang.chen@xxxxxxxxxxxxxxxx>>; Jack Zhu
<jack.zhu@xxxxxxxxxxxxxxxx<mailto:jack.zhu@xxxxxxxxxxxxxxxx>>; Changhuang Liang
<changhuang.liang@xxxxxxxxxxxxxxxx<mailto:changhuang.liang@xxxxxxxxxxxxxxxx>>;
maarten.lankhorst@xxxxxxxxxxxxxxx<mailto:maarten.lankhorst@xxxxxxxxxxxxxxx>;
suijingfeng@xxxxxxxxxxx<mailto:suijingfeng@xxxxxxxxxxx>
主题: Re: [v3 4/6] drm/vs: Add KMS crtc&plane
On Mon, Dec 04, 2023 at 08:33:13PM +0800, Keith Zhao wrote:
> +static const struct vs_plane_info dc_hw_planes_rev0[PLANE_NUM] = {
{
.name = "Primary",
.id = PRIMARY_PLANE_0,
.type = DRM_PLANE_TYPE_PRIMARY,
.num_formats = ARRAY_SIZE(primary_overlay_format0),
.formats = primary_overlay_format0,
.num_modifiers = ARRAY_SIZE(format_modifier0),
.modifiers = format_modifier0,
.min_width = 0,
.min_height = 0,
.max_width = 4096,
.max_height = 4096,
.rotation = DRM_MODE_ROTATE_0 |
DRM_MODE_ROTATE_90 |
DRM_MODE_ROTATE_180 |
DRM_MODE_ROTATE_270 |
DRM_MODE_REFLECT_X |
DRM_MODE_REFLECT_Y,
.blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE),
.color_encoding = BIT(DRM_COLOR_YCBCR_BT709) |
BIT(DRM_COLOR_YCBCR_BT2020),
.degamma_size = DEGAMMA_SIZE,
.min_scale = FRAC_16_16(1, 3),
.max_scale = FRAC_16_16(10, 1),
.zpos = 0,
.watermark = true,
.color_mgmt = true,
.roi = true,
},
{
.name = "Overlay",
.id = OVERLAY_PLANE_0,
.type = DRM_PLANE_TYPE_OVERLAY,
.num_formats = ARRAY_SIZE(primary_overlay_format0),
.formats = primary_overlay_format0,
.num_modifiers = ARRAY_SIZE(format_modifier0),
.modifiers = format_modifier0,
.min_width = 0,
.min_height = 0,
.max_width = 4096,
.max_height = 4096,
.rotation = DRM_MODE_ROTATE_0 |
DRM_MODE_ROTATE_90 |
DRM_MODE_ROTATE_180 |
DRM_MODE_ROTATE_270 |
DRM_MODE_REFLECT_X |
DRM_MODE_REFLECT_Y,
.blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE),
.color_encoding = BIT(DRM_COLOR_YCBCR_BT709) |
BIT(DRM_COLOR_YCBCR_BT2020),
.degamma_size = DEGAMMA_SIZE,
.min_scale = FRAC_16_16(1, 3),
.max_scale = FRAC_16_16(10, 1),
.zpos = 1,
.watermark = true,
.color_mgmt = true,
.roi = true,
},
{
.name = "Overlay_1",
.id = OVERLAY_PLANE_1,
.type = DRM_PLANE_TYPE_OVERLAY,
.num_formats = ARRAY_SIZE(primary_overlay_format0),
.formats = primary_overlay_format0,
.num_modifiers =
dary_format_modifiers),
.modifiers = secondary_format_modifiers,
.min_width = 0,
.min_height = 0,
.max_width = 4096,
.max_height = 4096,
.rotation = 0,
.blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE),
.color_encoding = BIT(DRM_COLOR_YCBCR_BT709) |
BIT(DRM_COLOR_YCBCR_BT2020),
.degamma_size = DEGAMMA_SIZE,
.min_scale = DRM_PLANE_NO_SCALING,
.max_scale = DRM_PLANE_NO_SCALING,
.zpos = 2,
.watermark = true,
.color_mgmt = true,
.roi = true,
},
{
.name = "Primary_1",
.id = PRIMARY_PLANE_1,
.type = DRM_PLANE_TYPE_PRIMARY,
.num_formats = ARRAY_SIZE(primary_overlay_format0),
.formats = primary_overlay_format0,
.num_modifiers = ARRAY_SIZE(format_modifier0),
.modifiers = format_modifier0,
.min_width = 0,
.min_height = 0,
.max_width = 4096,
.max_height = 4096,
.rotation = DRM_MODE_ROTATE_0 |
DRM_MODE_ROTATE_90 |
DRM_MODE_ROTATE_180 |
DRM_MODE_ROTATE_270 |
DRM_MODE_REFLECT_X |
DRM_MODE_REFLECT_Y,
.blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE),
.color_encoding = BIT(DRM_COLOR_YCBCR_BT709) |
BIT(DRM_COLOR_YCBCR_BT2020),
.degamma_size = DEGAMMA_SIZE,
.min_scale = FRAC_16_16(1, 3),
.max_scale = FRAC_16_16(10, 1),
.zpos = 3,
.watermark = true,
.color_mgmt = true,
.roi = true,
},
{
.name = "Overlay_2",
.id = OVERLAY_PLANE_2,
.type = DRM_PLANE_TYPE_OVERLAY,
.num_formats = ARRAY_SIZE(primary_overlay_format0),
.formats = primary_overlay_format0,
.num_modifiers = ARRAY_SIZE(format_modifier0),
.modifiers = format_modifier0,
.min_width = 0,
.min_height = 0,
.max_width = 4096,
.max_height = 4096,
.rotation = DRM_MODE_ROTATE_0 |
DRM_MODE_ROTATE_90 |
DRM_MODE_ROTATE_180 |
DRM_MODE_ROTATE_270 |
DRM_MODE_REFLECT_X |
DRM_MODE_REFLECT_Y,
.blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE),
.color_encoding = BIT(DRM_COLOR_YCBCR_BT709) |
BIT(DRM_COLOR_YCBCR_BT2020),
.degamma_size = DEGAMMA_SIZE,
.min_scale = FRAC_16_16(1, 3),
.max_scale = FRAC_16_16(10, 1),
.zpos = 4,
.watermark = true,
.color_mgmt = true,
.roi = true,
},
{
.name = "Overlay_3",
.id = OVERLAY_PLANE_3,
.type = DRM_PLANE_TYPE_OVERLAY,
.num_formats = ARRAY_SIZE(primary_overlay_format0),
.formats = primary_overlay_format0,
.num_modifiers =
dary_format_modifiers),
.modifiers = secondary_format_modifiers,
.min_width = 0,
.min_height = 0,
.max_width = 4096,
.max_height = 4096,
.rotation = 0,
.blend_mode = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE),
.color_encoding = BIT(DRM_COLOR_YCBCR_BT709) |
BIT(DRM_COLOR_YCBCR_BT2020),
.degamma_size = DEGAMMA_SIZE,
.min_scale = DRM_PLANE_NO_SCALING,
.max_scale = DRM_PLANE_NO_SCALING,
.zpos = 5,
.watermark = true,
.color_mgmt = true,
.roi = true,
},
{
.name = "Cursor",
.id = CURSOR_PLANE_0,
.type = DRM_PLANE_TYPE_CURSOR,
.num_formats = ARRAY_SIZE(cursor_formats),
.formats = cursor_formats,
.num_modifiers = 0,
.modifiers = NULL,
.min_width = 32,
.min_height = 32,
.max_width = 64,
.max_height = 64,
.rotation = 0,
.degamma_size = 0,
.min_scale = DRM_PLANE_NO_SCALING,
.max_scale = DRM_PLANE_NO_SCALING,
.zpos = 255,
.watermark = false,
.color_mgmt = false,
.roi = false,
},
{
.name = "Cursor_1",
.id = CURSOR_PLANE_1,
.type = DRM_PLANE_TYPE_CURSOR,
.num_formats = ARRAY_SIZE(cursor_formats),
.formats = cursor_formats,
.num_modifiers = 0,
.modifiers = NULL,
.min_width = 32,
.min_height = 32,
.max_width = 64,
.max_height = 64,
.rotation = 0,
.degamma_size = 0,
.min_scale = DRM_PLANE_NO_SCALING,
.max_scale = DRM_PLANE_NO_SCALING,
.zpos = 255,
.watermark = false,
.color_mgmt = false,
.roi = false,
},
> +static const struct vs_dc_info dc8200_info = {
= "DC8200",
.panel_num = 2,
.plane_num = 8,
= dc_hw_planes_rev0,
.layer_num = 6,
.max_bpc = 10,
.color_formats = DRM_COLOR_FORMAT_RGB444 |
DRM_COLOR_FORMAT_YCBCR444 |
DRM_COLOR_FORMAT_YCBCR422 |
DRM_COLOR_FORMAT_YCBCR420,
.gamma_size = GAMMA_EX_SIZE,
.gamma_bits = 12,
.pitch_alignment = 128,
.pipe_sync = false,
.background = true,
.panel_sync = true,
.cap_dec = true,
I really think that entire thing is to workaround a suboptimal device tree
You should have two CRTCs in the device tree, you'll probe twice,
and you won't get to do that whole dance.
tried to modify it according to this idea Found it too difficult In
of hardware, the two crtc designs are too close to separate, and
are even designed into the same reg with different bits
crtc0 and crtc1. It seems not easy to described the 2
hardware by 2 device nodes
these bits doing?
A54F5.ECEA9C10]
bit0 and bit1 match ctrc0 and crtc1 , it is used to start crtc
exists for other register definitions.
is that ctrc0 and crtc1 have the same function and their offset is continuous,
being a continuous area, crtc1 being a continuous area
two separate devices, the device node dts reg attribute would be complex
going to have one big device in the DT with all
why do we need the display-subsystem device? Just
on the dc8200 device.
>signature.asc

Next message: Andrew Lunn: "Re: [PATCH v3 2/2] net: phy: dp83826: support TX data voltage tuning"
Previous message: Ilya Dryomov: "[GIT PULL] Ceph fixes for 6.8-rc4"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]