Re: [PATCH v2 1/2] signal: add the "int si_code" arg to prepare_kill_siginfo()

From: Christian Brauner
Date: Fri Feb 09 2024 - 10:10:49 EST


On Fri, Feb 09, 2024 at 02:06:20PM +0100, Oleg Nesterov wrote:
> So that do_tkill() can use this helper too. This also simplifies
> the next patch.
>
> TODO: perhaps we can kill prepare_kill_siginfo() and change the
> callers to use SEND_SIG_NOINFO, but this needs some changes in
> __send_signal_locked() and TP_STORE_SIGINFO().
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>