Re: [PATCH v5 09/12] cifs: Cut over to using netfslib

[Simon Horman]

On Mon, Feb 05, 2024 at 10:57:21PM +0000, David Howells wrote:

..

> diff --git a/fs/smb/client/cifsfs.h b/fs/smb/client/cifsfs.h
> index e8e0f863e935..5cd547b7b5ea 100644
> --- a/fs/smb/client/cifsfs.h
> +++ b/fs/smb/client/cifsfs.h
> @@ -85,6 +85,7 @@ extern const struct inode_operations cifs_namespace_inode_operations;
>  
>  
>  /* Functions related to files and directories */
> +extern const struct netfs_request_ops cifs_req_ops;
>  extern const struct file_operations cifs_file_ops;
>  extern const struct file_operations cifs_file_direct_ops; /* if directio mnt */
>  extern const struct file_operations cifs_file_strict_ops; /* if strictio mnt */

Nit: this hunk would probably be better placed in the
     patch at adds cifs_req_ops to fs/smb/client/file.c

..