Re: [PATCH v14 01/53] xhci: fix possible null pointer dereference at secondary interrupter removal

From: Greg KH
Date: Fri Feb 09 2024 - 05:25:31 EST


On Thu, Feb 08, 2024 at 03:13:14PM -0800, Wesley Cheng wrote:
> From: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>
> Don't try to remove a secondary interrupter that is known to be invalid.
> Also check if the interrupter is valid inside the spinlock that protects
> the array of interrupters.
>
> Found by smatch static checker
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-usb/ffaa0a1b-5984-4a1f-bfd3-9184630a97b9@moroto.mountain/
> Fixes: c99b38c41234 ("xhci: add support to allocate several interrupters")
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20240125152737.2983959-2-mathias.nyman@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Wesley Cheng <quic_wcheng@xxxxxxxxxxx>

Wait, this is already in my tree, right? Why keep sending it?

confused,

greg k-h