Re: [PATCH v3 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

From: Hannes Reinecke
Date: Fri Feb 09 2024 - 05:19:26 EST

On 2/7/24 23:20, Lee Duncan wrote:
From: Lee Duncan <lduncan@xxxxxxxx>

This reverts commit 1a1975551943f681772720f639ff42fbaa746212

This commit causes interrupts to be lost for FCoE devices,
since it changed sping locks from "bh" to "irqsave".

Instead, a work queue should be used, and will be addressed
in a separate patch.

Fixes: 1a1975551943f681772720f639ff42fbaa746212
Please use the correct fixes tag:

Fixes: 1a1975551943 ("scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock")

Otherwise looks good.


Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich