Re: [PATCH] dt-bindings: media: convert Mediatek consumer IR to the json-schema

[AngeloGioacchino Del Regno]

Il 09/02/24 08:24, Rafał Miłecki ha scritto:
> On 24.01.2024 13:33, AngeloGioacchino Del Regno wrote:
> > The driver says:
> >
> >      ir->bus = devm_clk_get(dev, "bus");
> >      if (IS_ERR(ir->bus)) {
> >          /*
> >           * For compatibility with older device trees try unnamed
> >           * ir->bus uses the same clock as ir->clock.
> >           */
> >          ir->bus = ir->clk;
> >      }
> >
> > This makes me think that requiring *one* clock on MT7623 would be a mistake
> > and the devicetree should use clk, bus - CLK_INFRA_IRRX_PD, CLK_TOP_F10M_REF_SEL.
>
> Looking at mt2701-clk.h I can see CLK_INFRA_IRRX (which I guess you
> meant above).
>
> I can't find CLK_TOP_F10M_REF_SEL however. This seems to be available on
> MT7622 and MT7629 only.
> Could you take another look at it, please? Can you somehow verify what
> clock should be used by IR on MT7623?

For MT2701/MT7623N you can use topckgen CLK_TOP_AXI_SEL as bus clock.

Cheers,
Angelo