Re: [PATCH v2] docs: scripts: sphinx-pre-install: Fix building docs with pyyaml package

From: Thorsten Blum
Date: Thu Feb 08 2024 - 15:15:32 EST



> On Feb 8, 2024, at 17:37, Vegard Nossum <vegard.nossum@xxxxxxxxxx> wrote:
>
> On 08/02/2024 14:13, Thorsten Blum wrote:
>> The Python module pyyaml is required to build the docs, but it is only
>> listed in Documentation/sphinx/requirements.txt and is therefore missing
>> when Sphinx is installed as a package and not via pip/pypi.
>> Add pyyaml as an optional package for Debian- and Red Hat-based distros to
> s/optional/required/ ? Given...

The commit message should be correct. The system package is optional, but the
Python module itself is required.

> Can/should we add it to give_opensuse_hints() as well, given that it
> also apparently allows you to install Sphinx via the distro package
> manager? (Not sure about mageia/arch/gentoo.)

Yes, I'll submit a v3 shortly.

Thanks,
Thorsten