Re: [PATCH stable 5.4] net: bcmgenet: Fix EEE implementation

From: Greg KH
Date: Thu Feb 08 2024 - 13:59:34 EST

On Thu, Feb 08, 2024 at 10:20:40AM -0800, Florian Fainelli wrote:
> commit a9f31047baca57d47440c879cf259b86f900260c upstream
> We had a number of short comings:
> - EEE must be re-evaluated whenever the state machine detects a link
> change as wight be switching from a link partner with EEE
> enabled/disabled
> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
> transmit path, which applies to the TBUF block
> - We do not need to forcibly enable EEE upon system resume, as the PHY
> state machine will trigger a link event that will do that, too
> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> Link:
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> Change-Id: I9e9d9d9e10817c7fcf3d9cde2389a1f6fe42a2ba

"Change-Id:"? Ick, gerrit, so sorry :(

Please remove these.


greg k-h