Re: [PATCH v1 14/15] dt-bindings: auxdisplay: Add Maxim MAX6958/6959

From: Conor Dooley
Date: Thu Feb 08 2024 - 12:51:26 EST

On Thu, Feb 08, 2024 at 06:58:57PM +0200, Andy Shevchenko wrote:
> Add initial device tree documentation for Maxim MAX6958/6959.

Why "initial"? Are there elements this display that you've not
documented yet?

> +title: MAX6958/6959 7-segment LED display controller with keyscan

> +properties:
> + compatible:
> + const: maxim,max6959

Where's the max6958's compatible? I don't see it in your driver either.
It seems that the max6959 has some interrupt capabilities that are not
available on the max6958, so a dedicated compatible seems suitable to


Attachment: signature.asc
Description: PGP signature