Re: [PATCH] pidfd: change pidfd_send_signal() to respect PIDFD_THREAD

From: Oleg Nesterov
Date: Thu Feb 08 2024 - 09:07:40 EST


On 02/08, Christian Brauner wrote:
>
> I would also suggest we update the obsolete comment on top of
> pidfd_send_signal() along the lines of:

Yes, but...

> + * If the @pidfd refers to a thread-group leader the signal is thread-group
> + * directed. If @pidfd referes to a thread then the signal is thread directed.

No, this depends on PIDFD_THREAD only.

If it is set then the signal is always "thread directed" even if @pidfd refers
to a thread-group leader.

Otherwise the target task must be a group leader and the signal will be
"thread-group directed".

Right?

Oleg.