Re: [PATCH] gpio: remove GPIO device from the list unconditionally in error path

[Bartosz Golaszewski]

On Mon, Feb 5, 2024 at 11:22 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Since commit 48e1b4d369cf ("gpiolib: remove the GPIO device from the list
> when it's unregistered") we remove the GPIO device entry from the global
> list (used to order devices by their GPIO ranges) when unregistering the
> chip, not when releasing the device. It will not happen when the last
> reference is put anymore. This means, we need to remove it in error path
> in gpiochip_add_data_with_key() unconditionally, without checking if the
> device's .release() callback is set.
>
> Fixes: 48e1b4d369cf ("gpiolib: remove the GPIO device from the list when it's unregistered")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---

Queued for fixes.

Bart