RE: [PATCH rc 8/8] iommu/vt-d: Add missing dirty tracking set for parent domain

[Tian, Kevin]

> From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> Sent: Thursday, February 8, 2024 4:23 PM
> 
> @@ -4760,6 +4790,12 @@ static int intel_iommu_set_dirty_tracking(struct
> iommu_domain *domain,
>  	if (ret)
>  		goto err_unwind;
> 
> +	if (dmar_domain->nested_parent) {
> +		ret = parent_domain_set_dirty_tracking(dmar_domain,
> enable);
> +		if (ret)
> +			goto err_unwind;
> +	}
> +

there also lack of setting dirty tracking when a device is attached to the
nested domain while the parent already has dirty-tracking enabled.

but looks even w/o nesting this is missed in the attach path.

could be fixed separately. so for this one:

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>