Re: [PATCH net-next] net: sfp: add quirk for OEM DFP-34X-2C2 GPON ONU SFP

[Sergio Palumbo]

Hello Russell,
I did the requested test

- host that supports 1000base-X and 2500base-X with your quirk (Banana PI R3)
- SFP inserted with LAN_SDS_MODE=1 (DFP-34X-2C2

and here below system messages concerning sfp:

Sun Feb  4 00:35:06 2024 kern.info kernel: [   14.686771] sfp sfp-1: 
Host maximum power 3.0W
Sun Feb  4 00:35:06 2024 kern.info kernel: [   14.692137] sfp sfp-2: 
Host maximum power 3.0W
Sun Feb  4 00:35:06 2024 kern.info kernel: [   15.029727] sfp sfp-1: 
module OEM              DFP-34X-2C2      rev      sn XPONxxxxxxxx     dc 
230912
Sun Feb  4 00:35:06 2024 kern.info kernel: [   15.068806] sfp sfp-2: 
module                                   rev 1.0  sn 2307210038       dc 
230721
Sun Feb  4 00:35:08 2024 kern.info kernel: [   22.767328] mt7530-mdio 
mdio-bus:1f sfp2: configuring for inband/2500base-x link mode
Sun Feb  4 00:35:08 2024 kern.info kernel: [   22.777097] br-lan: port 
5(sfp2) entered blocking state
Sun Feb  4 00:35:08 2024 kern.info kernel: [   22.782390] br-lan: port 
5(sfp2) entered disabled state
Sun Feb  4 00:35:12 2024 kern.info kernel: [   26.970294] mt7530-mdio 
mdio-bus:1f sfp2: Link is Up - 2.5Gbps/Full - flow control off
Sun Feb  4 00:35:12 2024 kern.info kernel: [   26.978403] br-lan: port 
5(sfp2) entered blocking state
Sun Feb  4 00:35:12 2024 kern.info kernel: [   26.983623] br-lan: port 
5(sfp2) entered forwarding state
Sun Feb  4 00:35:12 2024 daemon.notice netifd: Network device 'sfp2' 
link is up
Sun Feb  4 00:35:08 2024 kern.info kernel: [   22.834307] mtk_soc_eth 
15100000.ethernet eth1: configuring for inband/2500base-x link mode
Sun Feb  4 00:35:08 2024 kern.info kernel: [   22.846214] device eth1 
entered promiscuous mode
Sun Feb  4 00:35:58 2024 kern.info kernel: [   72.800035] mtk_soc_eth 
15100000.ethernet eth1: Link is Up - 2.5Gbps/Full - flow control off

sfp-1 is linked to eth1
eth1 is running at 2500base-x

Same result with ethtool:

Settings for eth1:
        Supported ports: [ FIBRE ]
        Supported link modes:   2500baseX/Full
                                1000baseX/Full
        Supported pause frame use: Symmetric Receive-only
        Supports auto-negotiation: Yes
        Supported FEC modes: Not reported
        Advertised link modes:  2500baseX/Full
        Advertised pause frame use: Symmetric Receive-only
        Advertised auto-negotiation: Yes
        Advertised FEC modes: Not reported
        Speed: 2500Mb/s
        Duplex: Full
        Auto-negotiation: on
        Port: FIBRE
        PHYAD: 0
        Transceiver: internal
        Current message level: 0x000000ff (255)
                               drv probe link timer ifdown ifup rx_err 
tx_err
        Link detected: yes

Please let me have your comments.

Sergio Palumbo


Il 06/02/2024 15:15, Russell King (Oracle) ha scritto:
> Hi Sergio,
>
> I did ask for the kernel messages from a specific scenario:
>
> - host that supports 1000base-X and 2500base-X with your quirk
> - SFP inserted with LAN_SDS_MODE=1
>
> What I expet to see in the kernel messages is that the system will
> use 2500base-X, and a failure.
>
> You claim that the kernel will link at 1000base-X. There is no
> mechanism in the kernel for this to happen, and I believe that
> if you look at the kernel messages, this will prove my point.