RE: [EXT] Re: [PATCH net-next v6 5/8] octeon_ep_vf: add support for ndo ops

[Shinas Rasheed]

From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@xxxxxxxxxxxx> 
Sent: Wednesday, February 7, 2024 1:40 PM
To: Shinas Rasheed <srasheed@xxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Haseeb Gani <hgani@xxxxxxxxxxx>; Vimlesh Kumar <vimleshk@xxxxxxxxxxx>; Sathesh B Edara <sedara@xxxxxxxxxxx>; egallen@xxxxxxxxxx; mschmidt@xxxxxxxxxx; pabeni@xxxxxxxxxx; kuba@xxxxxxxxxx; horms@xxxxxxxxxx; wizhao@xxxxxxxxxx; kheib@xxxxxxxxxx; konguyen@xxxxxxxxxx; Veerasenareddy Burru <vburru@xxxxxxxxxxx>; Satananda Burla <sburla@xxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>
Subject: [EXT] Re: [PATCH net-next v6 5/8] octeon_ep_vf: add support for ndo ops

On Wed, Feb 7, 2024 at 12:23 PM Shinas Rasheed <mailto:srasheed@xxxxxxxxxxx> wrote:
Add support for ndo ops to set MAC address, change MTU, get stats.
Add control path support to set MAC address, change MTU, get stats,
set speed, get and set link mode.
[Kalesh]: You are adding support for only one ndo hook ".ndo_get_stats64" in this patch. Am I missing something?

Signed-off-by: Shinas Rasheed <mailto:srasheed@xxxxxxxxxxx>

+int octep_vf_get_if_stats(struct octep_vf_device *oct)
[Kalesh]: You may want to make this function static. 

This is an interface api which is used in patch [7/8]

+{
+       struct octep_vf_iface_rxtx_stats vf_stats;
+       int ret, size;
+
+       memset(&vf_stats, 0, sizeof(struct octep_vf_iface_rxtx_stats));
[Kalesh]: You can avoid memset by initializing vf_stats = {}; 
+       ret = octep_vf_mbox_bulk_read(oct, OCTEP_PFVF_MBOX_CMD_GET_STATS,
+                                     (u8 *)&vf_stats, &size);
+       if (!ret) {