Re: [PATCH v4 0/3] arm64: dts: qcom: sc8280xp-x13s: Enable touchscreen

From: Steev Klimaszewski
Date: Wed Jan 31 2024 - 23:04:39 EST


On Wed, Jan 31, 2024 at 9:07 PM Bjorn Andersson
<quic_bjorande@xxxxxxxxxxx> wrote:
>
> This documents and defines the necessary properties for the I2C
> HID-based touchscreen found in some SKUs of the Lenovo Thinkpad X13s to
> work.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
> ---
> Changes in v4:
> - Introduced the patch in the HID driver removing the comment about the
> need to update the binding.
> - Link to v3: https://lore.kernel.org/r/20240129-x13s-touchscreen-v3-0-c4a933034145@xxxxxxxxxxx
>
> Changes in v3:
> - Rewrote the commit message, to properly describe the problem being
> resolved.
> - Link to v2: https://lore.kernel.org/r/20240126-x13s-touchscreen-v2-0-5374ccc9e10d@xxxxxxxxxxx
>
> Changes in v2:
> - Dropped output-high from &ts0_default, to avoid bouncing the reset
> line unnecessarily
> - Link to v1: https://lore.kernel.org/r/20240125-x13s-touchscreen-v1-0-ab8c882def9c@xxxxxxxxxxx
>
> ---
> Bjorn Andersson (3):
> dt-bindings: HID: i2c-hid: Document reset-related properties
> HID: i2c-hid-of: Remove comment about post-reset in DT binding
> arm64: dts: qcom: sc8280xp-x13s: Fix/enable touchscreen
>
> Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 7 +++++--
> drivers/hid/i2c-hid/i2c-hid-of.c | 5 -----
> 3 files changed, 11 insertions(+), 7 deletions(-)
> ---
> base-commit: 8bf1262c53f50fa91fe15d01e5ef5629db55313c
> change-id: 20240125-x13s-touchscreen-48012ff3c24e
>
> Best regards,
> --
> Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
>
>
Thank you for this work!

Works great on my Thinkpad X13s
Tested-by: Steev Klimaszewski <steev@xxxxxxxx>