Re: [PATCH v2] fscrypt: to make sure the inode->i_blkbits is correctly set

[Eric Biggers]

On Thu, Feb 01, 2024 at 08:35:25AM +0800, xiubli@xxxxxxxxxx wrote:
> From: Xiubo Li <xiubli@xxxxxxxxxx>
> 
> The inode->i_blkbits should be already set before calling
> fscrypt_get_encryption_info() and it will use this to setup the
> ci_data_unit_bits later.
> 
> URL: https://tracker.ceph.com/issues/64035
> Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx>

Thanks, applied.  I adjusted the commit message to make it clear what the patch
actually does:

commit 5befc19caec93f0088595b4d28baf10658c27a0f
Author: Xiubo Li <xiubli@xxxxxxxxxx>
Date:   Thu Feb 1 08:35:25 2024 +0800

    fscrypt: explicitly require that inode->i_blkbits be set

    Document that fscrypt_prepare_new_inode() requires inode->i_blkbits to
    be set, and make it WARN if it's not.  This would have made the CephFS
    bug https://tracker.ceph.com/issues/64035 a bit easier to debug.

    Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20240201003525.1788594-1-xiubli@xxxxxxxxxx
    Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>