RE: [PATCH] wifi: rtl8xxxu: fix error messages

From: Ping-Ke Shih
Date: Wed Jan 31 2024 - 20:13:08 EST




> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Wednesday, January 31, 2024 3:10 PM
> To: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx>
> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; Ping-Ke Shih
> <pkshih@xxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH] wifi: rtl8xxxu: fix error messages
>
> The first parameter of WARN_ONCE() is a condition so this code will end
> up printing the function name instead of the proper message.
>
> Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>