Re: [PATCH 1/1] block: print warning when invalid domain set to ioprio

From: Damien Le Moal
Date: Wed Jan 31 2024 - 19:04:13 EST


On 2/1/24 08:34, Zhaoyang Huang wrote:
> On Wed, Jan 31, 2024 at 9:07 PM Niklas Cassel <Niklas.Cassel@xxxxxxx> wrote:
>> This sound like either a bug in the FS or by some of your local changes
>> that you did for your other patch (ioprio based on activity).
> Yes. That's why I would like to suggest adding some information here
> to help developers find the clue quickly.

The backtrace was not clear enough ?

When a request reaches mq-deadline, the request priority is supposed to be
correct already. Your changes had a bug and broke that assumption. Please fix
that instead of adding error messages for errors that should never happen in the
first place.

--
Damien Le Moal
Western Digital Research