Re: [PATCH 2/6] PCI: dwc: Change arguments of dw_pcie_prog_outbound_atu()

From: Bjorn Helgaas
Date: Wed Jan 31 2024 - 13:23:16 EST


On Wed, Jan 31, 2024 at 10:56:01AM -0500, Frank Li wrote:
> On Wed, Jan 31, 2024 at 09:41:15AM -0600, Bjorn Helgaas wrote:
> > Nit: could the subject line be more specific than "change arguments"?
> > E.g., something about collecting dw_pcie_prog_outbound_atu() arguments
> > in a struct? If you know that's the fundamental change, it's a lot
> > easier to read the commit log and the patch because you know the goal.
>
> How about
> "Consolidate arguments of dw_pcie_prog_outbound_atu() into a structure"

Sounds good!