Re: [PATCH v3] dt-bindings: iio: afe: voltage-divider: Add io-channel-cells

[Conor Dooley]

On Wed, Jan 31, 2024 at 04:35:16PM +0000, Jonathan Cameron wrote:
> On Wed, 31 Jan 2024 09:29:59 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> 
> > On 30/01/2024 12:56, Naresh Solanki wrote:
> > > voltage-divider is always an iio consumer at the same time it is
> > > optionally an iio provider.
> > > Hence add #io-channel-cells
> > > Also update example.
> > >   
> > 
> > Fix
> > wrapping
> > and
> > proper
> > sentences. Each sentence finishes with full stop.
> > 
> > ...
> > >    output-ohms:
> > >      description:
> > >        Resistance Rout over which the output voltage is measured. See full-ohms.
> > > @@ -75,12 +82,17 @@ examples:
> > >              spi-max-frequency = <1000000>;
> > >          };
> > >      };
> > > -    sysv {
> > > +    p12v_vd: sysv {  
> > 
> > No, drop label.
> > 
> > >          compatible = "voltage-divider";
> > >          io-channels = <&maxadc 1>;
> > > +        #io-channel-cells = <1>;
> > >  
> > >          /* Scale the system voltage by 22/222 to fit the ADC range. */
> > >          output-ohms = <22>;
> > >          full-ohms = <222>; /* 200 + 22 */
> > >      };
> > > +    iio-hwmon {
> > > +        compatible = "iio-hwmon";
> > > +        io-channels = <&p12v_vd 0>;  
> > 
> > The same question as for v2. Drop unrelated example.
> 
> Conor requested an example of the device acting as a consumer and a provider.
> Might have meant in the patch description?
> 
> Conor?

I wanted it in the property description to help with understanding when
to use it. I don't think the extra example nodes actually help you
understand what it is doing, only how to write one yourself once you
know you need it.

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature