Re: [net-next PATCH] octeontx2-pf: Add support to read eeprom information

From: Hariprasad Kelam
Date: Wed Jan 31 2024 - 06:40:55 EST




> On Thu, Jan 25, 2024 at 04:51:33PM +0530, Hariprasad Kelam wrote:
> > Add support to read/decode EEPROM module information using ethtool.
>
> It looks like you have a very primitive firmware here, which can only return the
> first page of the SFPs EEPROM. What are your plans to make this fully
> featured? Ideally you should not be using this API, but the newer API which
> indicates what page you would like to read.
>
Our firmware currently supports reading only first page.
Will submit V2 which uses new API considering the len/offset fields.

> > Signed-off-by: Christina Jacob <cjacob@xxxxxxxxxxx>
> > Signed-off-by: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> > Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxxx>
>
> These seem to be in the wrong order.
>
I will fix in next version.
Thanks,
Hariprasad k
> Andrew