Re: [PATCH] pinctrl: amd: Add IRQF_ONESHOT to the interrupt request

From: Linus Walleij
Date: Wed Jan 31 2024 - 04:09:58 EST


On Tue, Jan 23, 2024 at 7:08 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:

> On some systems the interrupt is shared between GPIO controller
> and ACPI SCI. When the interrupt is shared with the ACPI SCI the
> flags need to be identical.
>
> This should fix the GPIO controller failing to work after commit
> 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler for SCI").
> ```
> [ 0.417335] genirq: Flags mismatch irq 9. 00000088 (pinctrl_amd) vs. 00002080 (acpi)
> [ 0.420073] amd_gpio: probe of AMDI0030:00 failed with error -16
> ```
>
> Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Reported-by: Christian Heusel <christian@xxxxxxxxx>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218407
> Fixes: 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler for SCI")
> Link: https://lore.kernel.org/linux-acpi/CAJZ5v0iRqUXeuKmC_+dAJtDBLWQ3x15n4gRH48y7MEaLoXF+UA@xxxxxxxxxxxxxx/T/#mc5506014141b61e472b24e095889535a04458083
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Patch applied for fixes!

Thanks for dealing with these issues Mario!

Yours,
Linus Walleij