Re: [PATCH v3 0/6] usb: typec: qcom-pmic-typec: enable support for PMI632 PMIC

From: Luca Weiss
Date: Wed Jan 31 2024 - 02:49:30 EST


On Tue Jan 30, 2024 at 8:32 PM CET, Dmitry Baryshkov wrote:
> The Qualcomm PMI632 PMIC (found on Qualcomm Robotics RB2 platform)
> doesn't support USB Power Delivery. However this PMIC still supports
> handling of the Type-C port (orientation detection, etc). Reuse exiting
> qcom-pmic-typec driver to support Type-C related functionality of this
> PMIC. Use this to enable USB-C connector support on the RB2 platform.

Hi Dmitry,

In case you send a new revision you can drop my Tested-by on the RB2
patches since it's a different platform, and the tag on the dt-bindings
patches also don't make too much sense I think?

Thanks!

Regards
Luca

>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> Changes in v3:
> - Added constraints to qcom,pmic-typec / reg property (Krzysztof)
> - Dropped merged TCPM and Qualcomm PHY patches
> - Link to v2: https://lore.kernel.org/r/20240113-pmi632-typec-v2-0-182d9aa0a5b3@xxxxxxxxxx
>
> Changes in v2:
> - Split qcom_pmic_typec_pdphy_set_roles() changes to separate patch
> (Konrad)
> - Simplified devm_kzalloc / sizeof() argument (Konrad)
> - Made start / stop callbacks mandatory (Bryan)
> - Reworked Type-C port handling into a backend similar to PD PHY (Bryan)
> - Made more qcom-pmic-typec data static const (Bryan)
> - Squashed usbc PHY single-lane removal patch (Konrad)
> - Further usbc PHY cleanup (Konrad)
> - Fixed order of DT properties in pmi632.dtsi (Konrad)
> - Instead of specifying bogus PDOs for the port, specify pd-disable and
> typec-power-opmode properties for the connector
> - Moved orientation-switch / usb-dual-role properties to sm6115.dtsi
> (Konrad)
> - Linked usb_dwc3_ss and usb_qmpphy_usb_ss_in
> - Link to v1: https://lore.kernel.org/r/20240113-pmi632-typec-v1-0-de7dfd459353@xxxxxxxxxx
>
> ---
> Dmitry Baryshkov (5):
> dt-bindings: regulator: qcom,usb-vbus-regulator: add support for PMI632
> dt-bindings: usb: qcom,pmic-typec: add support for the PMI632 block
> usb: typec: qcom-pmic-typec: add support for PMI632 PMIC
> arm64: dts: qcom: pmi632: define USB-C related blocks
> arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling
>
> Vladimir Zapolskiy (1):
> arm64: dts: qcom: sm6115: drop pipe clock selection
>
> .../regulator/qcom,usb-vbus-regulator.yaml | 9 ++-
> .../devicetree/bindings/usb/qcom,pmic-typec.yaml | 32 ++++++++-
> arch/arm64/boot/dts/qcom/pmi632.dtsi | 30 ++++++++
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 50 +++++++++++++-
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 44 +++++++++++-
> drivers/usb/typec/tcpm/qcom/Makefile | 3 +-
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 30 ++++++--
> .../usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.h | 2 +
> .../typec/tcpm/qcom/qcom_pmic_typec_pdphy_stub.c | 80 ++++++++++++++++++++++
> 9 files changed, 266 insertions(+), 14 deletions(-)
> ---
> base-commit: 41d66f96d0f15a0a2ad6fa2208f6bac1a66cbd52
> change-id: 20240112-pmi632-typec-4c7533092387
>
> Best regards,