Re: [PATCH] MAINTAINERS: Add UBSAN section

From: Kees Cook
Date: Wed Jan 31 2024 - 01:03:05 EST


On Wed, Jan 31, 2024 at 02:41:16AM +0100, Andrey Konovalov wrote:
> On Wed, Jan 31, 2024 at 12:46 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >
> > The kernel hardening efforts have continued to depend more and more
> > heavily on UBSAN, so make an actual MAINTAINERS entry for it.
> >
> > Cc: Andrey Ryabinin <ryabinin.a.a@xxxxxxxxx>
> > Cc: Marco Elver <elver@xxxxxxxxxx>
> > Cc: Andrey Konovalov <andreyknvl@xxxxxxxxx>
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > ---
> > Hi! I figured since I've been carrying UBSAN changes more and more lately,
> > I would just make an actual entry in MAINTAINERS. Are you all interested
> > in being listed as reviewers? Or would you want to be M: instead?
> > ---
> > MAINTAINERS | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 8d1052fa6a69..19b8802b2f12 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22471,6 +22471,22 @@ F: Documentation/block/ublk.rst
> > F: drivers/block/ublk_drv.c
> > F: include/uapi/linux/ublk_cmd.h
> >
> > +UBSAN
> > +M: Kees Cook <keescook@xxxxxxxxxxxx>
> > +R: Andrey Ryabinin <ryabinin.a.a@xxxxxxxxx>
> > +R: Marco Elver <elver@xxxxxxxxxx>
> > +R: Andrey Konovalov <andreyknvl@xxxxxxxxx>
> > +L: linux-hardening@xxxxxxxxxxxxxxx
> > +S: Supported
> > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening
> > +F: Documentation/dev-tools/ubsan.rst
> > +F: include/linux/ubsan.h
> > +F: lib/Kconfig.ubsan
> > +F: lib/test_ubsan.c
> > +F: lib/ubsan.c
> > +F: scripts/Makefile.ubsan
> > +K: \bARCH_HAS_UBSAN\b
> > +
> > UCLINUX (M68KNOMMU AND COLDFIRE)
> > M: Greg Ungerer <gerg@xxxxxxxxxxxxxx>
> > L: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> > --
> > 2.34.1
> >
>
> Hi Kees,
>
> Perhaps, it also makes sense to add the kasan-dev@xxxxxxxxxxxxxxxx
> list. It's used for all other Sanitizers.

Okay, sure, I can add that. If it gets too noisy, we can always remove
it. :)

>
> Otherwise, looks good to me:
>
> Acked-by: Andrey Konovalov <andreyknvl@xxxxxxxxx>

Thanks!

--
Kees Cook