Re: [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers

From: Rob Herring
Date: Tue Jan 30 2024 - 15:39:29 EST


On Tue, Jan 23, 2024 at 09:33:12AM +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> index 7a4a6ab85970..5b9fda2a81e0 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> @@ -60,7 +60,7 @@ properties:
> be implemented in an always-on power domain."
>
> patternProperties:
> - '^frame@[0-9a-z]*$':
> + '^frame@[0-9a-f]*$':

Technically, it should be '+' rather than '*'. But I'm pretty sure
generically we check that node name can't end with '@'.