Re: [PATCH v1 06/18] thermal/drivers/rcar: Migrate to thermal_zone_device_register()

From: Niklas Söderlund
Date: Tue Jan 30 2024 - 10:09:16 EST


Hi AngeloGioacchino,

Thanks for your work.

On 2024-01-30 12:12:38 +0100, AngeloGioacchino Del Regno wrote:
> The thermal API has a new thermal_zone_device_register() function which
> is deprecating the older thermal_zone_device_register_with_trips() and
> thermal_tripless_zone_device_register().
>
> Migrate to the new thermal zone device registration function.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
> drivers/thermal/rcar_thermal.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index feb848d595fa..7bf9c1611a00 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -488,10 +488,17 @@ static int rcar_thermal_probe(struct platform_device *pdev)
> dev, i, priv,
> &rcar_thermal_zone_ops);
> } else {
> - priv->zone = thermal_zone_device_register_with_trips(
> - "rcar_thermal", trips, ARRAY_SIZE(trips), 0, priv,
> - &rcar_thermal_zone_ops, NULL, 0,
> - idle);
> + struct thermal_zone_device_params tzdp = {
> + .tzp = {
> + .type = "rcar_thermal",
> + .ops = &rcar_thermal_zone_ops,
> + .devdata = priv,
> + .trips = trips,
> + .num_trips = ARRAY_SIZE(trips),
> + .polling_delay = idle,
> + }
> + };
> + priv->zone = thermal_zone_device_register(&tzdp);
>
> ret = thermal_zone_device_enable(priv->zone);
> if (ret) {
> --
> 2.43.0
>

--
Kind Regards,
Niklas Söderlund