Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create

From: Nikolay Aleksandrov
Date: Tue Jan 30 2024 - 04:29:34 EST


On 30/01/2024 11:25, Kunwu Chan wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
> ---
> net/bridge/br_fdb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index c622de5eccd0..c77591e63841 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -35,10 +35,7 @@ static struct kmem_cache *br_fdb_cache __read_mostly;
>
> int __init br_fdb_init(void)
> {
> - br_fdb_cache = kmem_cache_create("bridge_fdb_cache",
> - sizeof(struct net_bridge_fdb_entry),
> - 0,
> - SLAB_HWCACHE_ALIGN, NULL);
> + br_fdb_cache = KMEM_CACHE(net_bridge_fdb_entry, SLAB_HWCACHE_ALIGN);
> if (!br_fdb_cache)
> return -ENOMEM;
>

Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>