Re: [PATCH net v3] net: dsa: qca8k: fix illegal usage of GPIO

From: patchwork-bot+netdevbpf
Date: Mon Jan 29 2024 - 21:40:34 EST


Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Fri, 26 Jan 2024 11:49:35 +0100 you wrote:
> When working with GPIO, its direction must be set either when the GPIO is
> requested by gpiod_get*() or later on by one of the gpiod_direction_*()
> functions. Neither of this is done here which results in undefined
> behavior on some systems.
>
> As the reset GPIO is used right after it is requested here, it makes sense
> to configure it as GPIOD_OUT_HIGH right away. With that, the following
> gpiod_set_value_cansleep(1) becomes redundant and can be safely
> removed.
>
> [...]

Here is the summary with links:
- [net,v3] net: dsa: qca8k: fix illegal usage of GPIO
https://git.kernel.org/netdev/net/c/c44fc98f0a8f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html