Re: [PATCH v1 1/1] wq: Avoid using isolated cpus' timers on unbounded queue_delayed_work

From: Tejun Heo
Date: Mon Jan 29 2024 - 15:51:20 EST


On Mon, Jan 29, 2024 at 04:26:57PM -0300, Leonardo Bras wrote:
> > Isn't that still the same number of add_timer[_on]() calls?
>
> Yeah, sorry about this, what I meant was: If we are ok on calling
> add_timer_on() multiple times, I would rather go with the above version, as
> I think it's better for readability.

I don't know. It looks more verbose and less clear to me in that it isn't
immediately clear that every branch ends with timer being added. But this is
really minor, so unless you have a really strong opinion against the
suggested structured, can we just do that?

Thanks.

--
tejun