Re: [PATCHSET v3 wq/for-6.9] workqueue: Implement system-wide max_active for unbound workqueues

From: Lai Jiangshan
Date: Mon Jan 29 2024 - 11:07:53 EST


Hello, Tejun

On Fri, Jan 26, 2024 at 1:06 AM Tejun Heo <tj@xxxxxxxxxx> wrote:

> This patchset includes the following patches:
>
> 0001-workqueue-Move-pwq-max_active-to-wq-max_active.patch
> 0002-workqueue-Factor-out-pwq_is_empty.patch
> 0003-workqueue-Replace-pwq_activate_inactive_work-with-__.patch
> 0004-workqueue-Move-nr_active-handling-into-helpers.patch
> 0005-workqueue-Make-wq_adjust_max_active-round-robin-pwqs.patch
> 0006-workqueue-RCU-protect-wq-dfl_pwq-and-implement-acces.patch
> 0007-workqueue-Move-pwq_dec_nr_in_flight-to-the-end-of-wo.patch
> 0008-workqueue-Introduce-struct-wq_node_nr_active.patch
> 0009-workqueue-Implement-system-wide-nr_active-enforcemen.patch
> 0010-tools-workqueue-wq_dump.py-Add-node_nr-max_active-du.patch
>

I just left a small piece of comments on patch 8 and patch 9.
After they are resolved, for patch 1-9:

Reviewed-by: Lai Jiangshan <jiangshanlai@xxxxxxxxx>

Thanks
Lai