Re: [PATCH v8 0/7] Fixes and improvements for RS485

From: Lino Sanfilippo
Date: Sun Jan 28 2024 - 21:39:40 EST


Hi,

On 28.01.24 04:10, Greg KH wrote:
> ATTENTION: This e-mail is from an external sender. Please check attachments and links before opening e.g. with mouseover.
>
>
> On Fri, Jan 05, 2024 at 03:11:46PM +0100, Lino Sanfilippo wrote:
>> The following series includes some fixes and improvements around RS485 in
>> the serial core and UART drivers:
>>
>> Patch 1: serial: Do not hold the port lock when setting rx-during-tx GPIO
>> Patch 2: serial: core: set missing supported flag for RX during TX GPIO
>> Patch 3: serial: core: fix sanitizing check for RTS settings
>> Patch 4: serial: core: make sure RS485 cannot be enabled when it is not
>> supported
>> Patch 5: serial: core, imx: do not set RS485 enabled if it is not supported
>> Patch 6: serial: omap: do not override settings for RS485 support
>> Patch 7: serial: 8250_exar: Set missing rs485_supported flag
>>
>> Changes in v8:
>> - remove wrong setting of SER_RS485_RX_DURING_TX introduced with patch
>> version 7 (pointed out by Ilpo)
>> - fix commit message as pointed out by Ilpo
>
> Aren't these already in the tree? None of them apply, what am I doing
> wrong?
>
> confused,
>
> greg k-h


Right, the series is already applied. However patch 1 -
07c30ea5861f (" serial: Do not hold the port lock when setting rx-during-tx GPIO") -
still contains a flaw which is why I sent a v8 to correct that. I sent it a bit too late
obviously, sorry for that.
You can ignore series v8 and instead I can send a follow up patch that corrects the flaw.

Again, sorry for the confusion.

Regards,
Lino