Re: [PATCH 03/17] media: media-entity.h: Fix kerneldoc

From: Sakari Ailus
Date: Sat Jan 27 2024 - 04:48:47 EST


Hi Ricardo,

Thanks for the patchset.

On Fri, Jan 26, 2024 at 11:16:02PM +0000, Ricardo Ribalda wrote:
> The fields seems to be documented twice.
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> include/media/media-entity.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index 2b6cd343ee9e..c79176ed6299 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -337,10 +337,6 @@ enum media_entity_type {
> * @info.dev: Contains device major and minor info.
> * @info.dev.major: device node major, if the device is a devnode.
> * @info.dev.minor: device node minor, if the device is a devnode.
> - * @major: Devnode major number (zero if not applicable). Kept just
> - * for backward compatibility.
> - * @minor: Devnode minor number (zero if not applicable). Kept just
> - * for backward compatibility.

A similar patch by Randy Dunlap was recently merged. You can drop this one.

> *
> * .. note::
> *
>

--
Kind regards,

Sakari Ailus