Re: [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on

From: Tudor Ambarus
Date: Fri Jan 26 2024 - 22:51:35 EST




On 1/27/24 00:35, André Draszik wrote:
> This pclk clock is required any time we access the pinctrl registers of
> this block.
>
> Since pinctrl-samsung doesn't support a clock at the moment, we just
> keep the kernel from disabling it at boot, until we have an update for
> pinctrl-samsung to handle this required clock, at which point we'll be
> able to drop the flag again.
>
> Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>

> ---
> drivers/clk/samsung/clk-gs101.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
> index 4a0520e825b6..61bb0dcf84ee 100644
> --- a/drivers/clk/samsung/clk-gs101.c
> +++ b/drivers/clk/samsung/clk-gs101.c
> @@ -2848,7 +2848,7 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = {
> GATE(CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK,
> "gout_peric0_gpio_peric0_pclk", "mout_peric0_bus_user",
> CLK_CON_GAT_GOUT_BLK_PERIC0_UID_GPIO_PERIC0_IPCLKPORT_PCLK,
> - 21, 0, 0),
> + 21, CLK_IGNORE_UNUSED, 0),
> /* Disabling this clock makes the system hang. Mark the clock as critical. */
> GATE(CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK,
> "gout_peric0_lhm_axi_p_peric0_i_clk", "mout_peric0_bus_user",