Re: [PATCH] eventfs: Have inodes have unique inode numbers

From: Linus Torvalds
Date: Fri Jan 26 2024 - 18:23:43 EST


On Fri, 26 Jan 2024 at 15:11, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, 26 Jan 2024 at 15:04, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> >
> > Maybe we should take advantage of that historical oddity. All files
> > in eventfs have inode number 0, problem solved.
>
> That might not be a horrible idea.

Note the "might". I don't know why glibc would have special-cased
st_ino of 0, but I suspect it's some internal oddity in the readdir()
implementation.

So considering that we do have that commit 2adc376c5519, I suspect it
would just be more pain than its worth to try to teach user space
about the whole "no inode number" thing.

It might be safer to pick something like -1 instead.

Linus