Re: [PATCH v2 04/15] mux: add mux_chip_resume() function

From: Andy Shevchenko
Date: Fri Jan 26 2024 - 16:29:30 EST


On Fri, Jan 26, 2024 at 4:37 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> The mux_chip_resume() function restores a mux_chip using the cached state
> of each mux.

..

> +int mux_chip_resume(struct mux_chip *mux_chip)
> +{
> + int ret, i;
> +
> + for (i = 0; i < mux_chip->controllers; ++i) {
> + struct mux_control *mux = &mux_chip->mux[i];

> + if (mux->cached_state != MUX_CACHE_UNKNOWN) {

if (_state == ...)
continue;

?

> + ret = mux_control_set(mux, mux->cached_state);
> + if (ret < 0) {
> + dev_err(&mux_chip->dev, "unable to restore state\n");
> + return ret;
> + }
> + }
> + }
> + return 0;
> +}

--
With Best Regards,
Andy Shevchenko