Re: [PATCHv4 1/1] block: introduce content activity based ioprio

From: Niklas Cassel
Date: Fri Jan 26 2024 - 13:51:42 EST


On Fri, Jan 26, 2024 at 08:08:00PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@xxxxxxxxxx>

(snip)

> --- a/include/uapi/linux/ioprio.h
> +++ b/include/uapi/linux/ioprio.h
> @@ -71,12 +71,24 @@ enum {
> * class and level.
> */
> #define IOPRIO_HINT_SHIFT IOPRIO_LEVEL_NR_BITS
> +#ifdef CONFIG_CONTENT_ACT_BASED_IOPRIO
> +#define IOPRIO_HINT_NR_BITS 3
> +#else
> #define IOPRIO_HINT_NR_BITS 10
> +#endif

Remember, this is a uapi header.
The ABI cannot be one way if a certain Kconfig is set,
but another way if that same Kconfig is not set.

What could go wrong? :)


Kind regards,
Niklas