Re: [PATCH 05/11] arm64: Kconfig: Clean up tautological LLVM version checks

From: Mark Rutland
Date: Fri Jan 26 2024 - 12:00:36 EST


On Fri, Jan 26, 2024 at 09:10:25AM -0700, Nathan Chancellor wrote:
> On Fri, Jan 26, 2024 at 12:59:55PM +0000, Mark Rutland wrote:
> > On Thu, Jan 25, 2024 at 03:55:11PM -0700, Nathan Chancellor wrote:
> > > config CPU_BIG_ENDIAN
> > > bool "Build big-endian kernel"
> > > - depends on !LD_IS_LLD || LLD_VERSION >= 130000
> > > # https://github.com/llvm/llvm-project/commit/1379b150991f70a5782e9a143c2ba5308da1161c
> >
> > We can delete the URL here, since that was just to describe why this depended
> > upon LLVM 13+; it's weird for it to sit here on its own.
>
> I think this is the URL for the fix for the problem brought up by
> commit 146a15b87335 ("arm64: Restrict CPU_BIG_ENDIAN to GNU as or LLVM
> IAS 15.x or newer"), so I think it should stay? It does not look like I
> ever added a link or context for the LLD line, I definitely should have.

Whoops; I clearly misread that, and yes it should stay.

Sorry about that; for the patch as-is:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.