Re: [PATCH v2] mtd: spinand: add support for ESMT F50x1G41LB

From: Chuanhong Guo
Date: Thu Jan 25 2024 - 20:46:02 EST


Hi Miquel!

On Thu, Jan 25, 2024 at 1:08 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> > According to the datasheets, the ESMT chips actually have a 5 byte ID,
> > the last 3 bytes being 0x7F (JEDEC Maker Code Continuation Code). Why
> > can't we simply extend the ID in esmt.c (as you had it in your original
> > patch) and increase SPINAND_MAX_ID_LEN to 5? Or, alternatively, only
> > extend the ID to 4 bytes?
> >
> > If that is the way to go, I would be happy to provide the patches.
>
> Please send the patches. Chuanhong can you test them?

I think it should be fine to set MAX_ID_LEN to 5 and add more
0x7f to the ID definition. Unfortunately I don't have access to an
ESMT flash for a test.

--
Regards,
Chuanhong Guo