Re: [PATCH v2 11/28] spi: s3c64xx: move common code outside if else

[Sam Protsenko]

On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@linaroorg> wrote:
>
> Move common code outside if else to avoid code duplication.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>

>  drivers/spi/spi-s3c64xx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index b048e81e6207..107b4200ab00 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -286,20 +286,18 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma,
>         if (dma->direction == DMA_DEV_TO_MEM) {
>                 sdd = container_of((void *)dma,
>                         struct s3c64xx_spi_driver_data, rx_dma);
> -               config.direction = dma->direction;
>                 config.src_addr = sdd->sfr_start + S3C64XX_SPI_RX_DATA;
>                 config.src_addr_width = sdd->cur_bpw / 8;
>                 config.src_maxburst = 1;
> -               dmaengine_slave_config(dma->ch, &config);
>         } else {
>                 sdd = container_of((void *)dma,
>                         struct s3c64xx_spi_driver_data, tx_dma);
> -               config.direction = dma->direction;
>                 config.dst_addr = sdd->sfr_start + S3C64XX_SPI_TX_DATA;
>                 config.dst_addr_width = sdd->cur_bpw / 8;
>                 config.dst_maxburst = 1;
> -               dmaengine_slave_config(dma->ch, &config);
>         }
> +       config.direction = dma->direction;
> +       dmaengine_slave_config(dma->ch, &config);
>
>         desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents,
>                                        dma->direction, DMA_PREP_INTERRUPT);
> --
> 2.43.0.429.g432eaa2c6b-goog
>