Re: [PATCH v4 1/3] leds: ktd2692: move ExpressWire code to library

[Lee Jones]

On Mon, 22 Jan 2024, Duje Mihanović wrote:

> The ExpressWire protocol is shared between at least KTD2692 and KTD2801
> with slight differences such as timings and the former not having a
> defined set of pulses for enabling the protocol (possibly because it
> does not support PWM unlike KTD2801). Despite these differences the
> ExpressWire handling code can be shared between the two, so move it into
> a library in preparation for adding KTD2801 support.
> 
> Suggested-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>
> ---
>  MAINTAINERS                       |   7 +++
>  drivers/leds/Kconfig              |   4 ++
>  drivers/leds/Makefile             |   3 +
>  drivers/leds/flash/Kconfig        |   2 +-
>  drivers/leds/flash/leds-ktd2692.c | 116 +++++++++-----------------------------

>  drivers/leds/leds-expresswire.c   |  68 ++++++++++++++++++++++
>  include/linux/leds-expresswire.h  |  36 ++++++++++++

Please can you separate the Expresswire addition into its own patch?

>  7 files changed, 146 insertions(+), 90 deletions(-)

-- 
Lee Jones [李琼斯]