Re: [PATCH 2/2] ARM: configs: keystone: Remove this defconfig

From: Nishanth Menon
Date: Thu Jan 25 2024 - 08:42:07 EST


On 20:56-20240124, Arnd Bergmann wrote:
> On Wed, Jan 24, 2024, at 19:52, Andrew Davis wrote:
> > On 1/24/24 12:04 PM, Nishanth Menon wrote:
> >> On 11:31-20240124, Andrew Davis wrote:
> >>> On 1/24/24 10:41 AM, Nishanth Menon wrote:
> >>>>
> >>>> There are a bunch of downstream folks who will have recipe fails etc if
> >>>> we do that. I am not sure we need to go down that route.
> >>>>
> >>>
> >>> That is the point of this patch, we want to stop any remaining downstream
> >>> folks from using this defconfig. It is not maintained nor updated like
> >>> the multi_v7_defconfig, any new or needed options will only be added to
> >>> multi-v7 defconfig.
> >>>
> >>
> >> I am going to have to defer to ARM maintainers what they think..
> >> enabling LPAE etc in common multi_v7_config.
> >>
> >
> > We are not enabling LPAE in common multi_v7_config, that can't be
> > done as many plats do not support it. Keystone will use the new
> > multi_v7_lpae_defconfig which was just added:
> >
> > e9faf9b0b07a ("ARM: add multi_v7_lpae_defconfig")
> >
> > That is what prompted me to make this change, we now have a
> > commonish config that works for Keystone.
>
> I think adding keystone to multi_v7_defconfig is a good
> idea here for the reasons you explained. I don't mind keeping
> the other one around as well though, since keystone is
> a bit special.

Thanks Arnd.

Andrew,

Could you respin the series with just patch #1 and with the bloatmeter
details added to the commit message (please leave in NFS - that was
the standard operation mode for most of CI systems - I'd like to
continue leveraging that than have to hand test platforms.

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D