Re: [PATCH 10/15] tick: Assume the tick can't be stopped in NOHZ_MODE_INACTIVE mode

From: Thomas Gleixner
Date: Thu Jan 25 2024 - 04:40:20 EST


On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:
> The full-nohz update function checks if the nohz mode is active before
> proceeding. It considers one exception though: if the tick is already
> stopped even though the nohz mode is inactive, it still moves on in
> order to update/restart the tick if needed.
>
> However in order for the tick to be stopped, the nohz_mode has to be
> either NOHZ_MODE_LOWRES or NOHZ_MODE_HIGHRES. Therefore it doesn't make
> sense to test if the tick is stopped before verifying NOHZ_MODE_INACTIVE
> mode.
>
> Remove the needless related condition.
>
> Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>