Re: [PATCH] ipv6: Ensure natural alignment of const ipv6 loopback and router addresses

From: Paolo Abeni
Date: Thu Jan 25 2024 - 03:41:27 EST


On Mon, 2024-01-22 at 22:27 +0100, Helge Deller wrote:
> On a parisc64 kernel I notice sometimes this kernel warning:
> Kernel unaligned access to 0x40ff8814 at ndisc_send_skb+0xc0/0x4d8
>
> The address 0x40ff8814 points to the in6addr_linklocal_allrouters
> variable and the warning simply means that some ipv6 function tries to
> read a 64-bit word directly from the not-64-bit aligned
> in6addr_linklocal_allrouters variable.
>
> The patch below ensures that those ipv6 loopback and router addresses
> always will be naturally aligned and as such prevents unaligned accesses
> for all architectures.
>
> Signed-off-by: Helge Deller <deller@xxxxxx>

The patch LGTM, but the above looks like material for the 'net' tree,
would you mind sending a v2 including a relevant fixes tag, the target
tree in the subject prefix and possibly the stacktrace you observe?

Feel free to include my acked-by tag in v2.

Thanks,

Paolo