Re: [PATCH v3 02/10] ARM: dts: broadcom: bcmbca: Add NAND controller node

[William Zhang]

Hi Miquel,

On 1/24/24 09:30, Miquel Raynal wrote:
> Hi David,
>
> dregan@xxxxxxxxxxxx wrote on Tue, 23 Jan 2024 19:04:50 -0800:
>
> > From: William Zhang <william.zhang@xxxxxxxxxxxx>
> >
> > Add support for Broadcom STB NAND controller in BCMBCA ARMv7 chip dts
> > files.
> >
> > Signed-off-by: William Zhang <william.zhang@xxxxxxxxxxxx>
> > Reviewed-by: David Regan <dregan@xxxxxxxxxxxx>
> > ---
> > Changes in v3: None
> > ---
> > Changes in v2: None
> > ---
> >   arch/arm/boot/dts/broadcom/bcm47622.dtsi    | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm63138.dtsi    | 10 +++++++++-
> >   arch/arm/boot/dts/broadcom/bcm63148.dtsi    | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm63178.dtsi    | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm6756.dtsi     | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm6846.dtsi     | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm6855.dtsi     | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm6878.dtsi     | 17 +++++++++++++++++
> >   arch/arm/boot/dts/broadcom/bcm947622.dts    |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm963138.dts    |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm963138dvt.dts | 12 +++++-------
> >   arch/arm/boot/dts/broadcom/bcm963148.dts    |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm963178.dts    |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm96756.dts     |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm96846.dts     |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm96855.dts     |  4 ++++
> >   arch/arm/boot/dts/broadcom/bcm96878.dts     |  4 ++++
> >   17 files changed, 165 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/broadcom/bcm47622.dtsi b/arch/arm/boot/dts/broadcom/bcm47622.dtsi
> > index 7cd38de118c3..55ff18043d96 100644
> > --- a/arch/arm/boot/dts/broadcom/bcm47622.dtsi
> > +++ b/arch/arm/boot/dts/broadcom/bcm47622.dtsi
> > @@ -138,6 +138,23 @@ hsspi: spi@1000 {
> >   			status = "disabled";
> >   		};
> >   
> > +		nand_controller: nand-controller@1800 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			compatible = "brcm,nand-bcm63138", "brcm,brcmnand-v7.1", "brcm,brcmnand";
> > +			reg = <0x1800 0x600>, <0x2000 0x10>;
> > +			reg-names = "nand", "nand-int-base";
> > +			brcm,nand-use-wp = <0>;
> > +			status = "disabled";
> > +
> > +			nandcs: nand@0 {
> > +				compatible = "brcm,nandcs";
> > +				reg = <0>;
> > +				nand-on-flash-bbt;
> > +				brcm,nand-ecc-use-strap;
>
> Describing the NAND chip in a SoC DTSI does not look relevant to me.
> Even more if you add something like this nand-ecc-use-strap setting
> which is very board dependent.
I am not sure if I understand you comments correctly but are you 
suggesting to put this whole nand controller node into each board dts? 
We have other ip block nodes like SPI, uart in this same soc dtsi file 
too.  For all the bcmbca soc dtsi I am updating here(and its board 
design), we always use the strap to for ecc setting.  So I thought it 
should be okay to put brcm,nand-ecc-use-strap in the default dtsi file. 
For any board that uses the raw nand nand-ecc property, the board dts 
can do so and override the brcm,nand-ecc-use-strap setting.

> Same applies to your arm64 DT patch.
>
> Thanks,
> Miquèl

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature