Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver

[Cristian Ciocaltea]

On 1/24/24 11:16, Jonas Karlman wrote:
> On 2024-01-24 08:30, Andy Yan wrote:
>> Hi Cristian:
>>
>> On 1/24/24 10:42, Andy Yan wrote:
>>> Hi Cristian:
>>>
>>> On 1/24/24 08:58, Cristian Ciocaltea wrote:
>>>> On 1/22/24 14:14, Sascha Hauer wrote:
>>>>> On Fri, Jan 19, 2024 at 09:38:03PM +0200, Cristian Ciocaltea wrote:
>>>>>> Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC.

[...]

>>
>> How about add a PHY_MODE_HDMI to enum phy_mode, and pass this custom data by extend phy_configure_opts
>> or the submode of phy_set_mode_ext ?
> 
> Please see the patch "phy: Add HDMI configuration options" [1] from
> Sandor Yu. Also the series "drm/connector: Create HDMI Connector
> infrastructure" [2] from Maxime Ripard may be of interest.

Oh, nice, thanks for the heads up!

Regards,
Cristian

> [1] https://lore.kernel.org/all/19070c125268cfe900021dea6e7e8379b89c630e.1704785836.git.Sandor.yu@xxxxxxx/
> [2] https://lore.kernel.org/dri-devel/20231207-kms-hdmi-connector-state-v5-0-6538e19d634d@xxxxxxxxxx/
> 
> Regards,
> Jonas